Skip to content

Only print (skip) logs on --verbose#723

Closed
jviotti wants to merge 1 commit intomainfrom
verbose-skip
Closed

Only print (skip) logs on --verbose#723
jviotti wants to merge 1 commit intomainfrom
verbose-skip

Conversation

@jviotti
Copy link
Copy Markdown
Member

@jviotti jviotti commented Mar 10, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode
Copy link
Copy Markdown

augmentcode bot commented Mar 10, 2026

🤖 Augment PR Summary

Summary: This PR reduces default indexer log noise by printing (skip) messages only when --verbose is enabled.

Changes:

  • Compute a single verbose flag and thread-safely propagate it through DISPATCH to gate skip logging.
  • Keep schema URL mapping output (from => to) behind --verbose.
  • Update CLI rebuild tests to add --verbose when they assert cached/skip behavior or verbose mapping output.
  • Adjust the sandbox Makefile target to pass --verbose alongside --profile.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 11 files

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (community)

Details
Benchmark suite Current: 98aa364 Previous: 4fc6247 Ratio
Add one schema (0 existing) 23 ms 18 ms 1.28
Add one schema (100 existing) 61 ms 44 ms 1.39
Add one schema (1000 existing) 435 ms 315 ms 1.38
Cached rebuild (1 existing) 14 ms 11 ms 1.27
Cached rebuild (101 existing) 30 ms 26 ms 1.15
Cached rebuild (1001 existing) 191 ms 179 ms 1.07

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (enterprise)

Details
Benchmark suite Current: 98aa364 Previous: 4fc6247 Ratio
Add one schema (0 existing) 25 ms 20 ms 1.25
Add one schema (100 existing) 63 ms 45 ms 1.40
Add one schema (1000 existing) 416 ms 314 ms 1.32
Cached rebuild (1 existing) 14 ms 12 ms 1.17
Cached rebuild (101 existing) 30 ms 27 ms 1.11
Cached rebuild (1001 existing) 183 ms 175 ms 1.05

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti closed this Mar 11, 2026
@jviotti jviotti deleted the verbose-skip branch March 11, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant